Messages in this thread | | | Subject | Re: [PATCH v3 6/7] misc: bcm-vk: add Broadcom VK driver | From | Scott Branden <> | Date | Wed, 22 Apr 2020 15:01:45 -0700 |
| |
On 2020-04-22 9:13 a.m., Scott Branden wrote: > > > On 2020-04-22 4:35 a.m., Dan Carpenter wrote: >> On Wed, Apr 22, 2020 at 07:17:34PM +0800, kbuild test robot wrote: >>> Hi Scott, >>> >>> I love your patch! Perhaps something to improve: >>> >>> [auto build test WARNING on driver-core/driver-core-testing] >>> [also build test WARNING on next-20200421] >>> [cannot apply to char-misc/char-misc-testing kselftest/next >>> linus/master v5.7-rc2] >>> [if your patch is applied to the wrong git tree, please drop us a >>> note to help >>> improve the system. BTW, we also suggest to use '--base' option to >>> specify the >>> base tree in git format-patch, please see >>> https://stackoverflow.com/a/37406982] >>> >>> url: >>> https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200422-114528 >>> base: >>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git >>> 55623260bb33e2ab849af76edf2253bc04cb241f >>> reproduce: >>> # apt-get install sparse >>> # sparse version: v0.6.1-191-gc51a0382-dirty >>> make ARCH=x86_64 allmodconfig >>> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' >> ^^^^^^^^^^^^^^^^^^^ >> >> Sorry, you asked me about this earlier. You will need to add >> -D__CHECK_ENDIAN__ to enable these Sparse warnings. > This is strange. I ran the sparse build and thought I had fixed all > the issues. > I'll have to try again. > > One other question with the sparse build. I get many of the messages > printed but the build seems to go to the end (even without my patches > applied): > ./arch/x86/include/asm/paravirt.h:333:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:338:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:338:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:343:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:343:9: error: got __inline > ./arch/x86/include/asm/paravirt.h:348:9: error: Expected ( after asm > ./arch/x86/include/asm/paravirt.h:348:9: error: too many errors > > Any way to suppress or I am doing something wrong? I just run the 2 > make commands: > > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' I figured out the sparse utility on ubuntu 18.04 is out of date causing the issue. > >> regards, >> dan carpenter >> >
| |