Messages in this thread | | | From | Ulf Hansson <> | Date | Wed, 22 Apr 2020 18:59:35 +0200 | Subject | Re: [PATCH 10/23] sched,mmc: Convert to sched_set_fifo*() |
| |
On Wed, 22 Apr 2020 at 13:29, Peter Zijlstra <peterz@infradead.org> wrote: > > Because SCHED_FIFO is a broken scheduler model (see previous patches) > take away the priority field, the kernel can't possibly make an > informed decision. > > In this case, use fifo_low, because it only cares about being above > SCHED_NORMAL. Effectively no change in behaviour. > > Cc: ulf.hansson@linaro.org > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Reviewed-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
FYI: I am slowly moving towards removing the entire kthread for the sdio_irq_thread(). It shouldn't be too far off to be posted, one or two kernel releases or so.
Kind regards Uffe
> --- > drivers/mmc/core/sdio_irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/mmc/core/sdio_irq.c > +++ b/drivers/mmc/core/sdio_irq.c > @@ -139,11 +139,10 @@ EXPORT_SYMBOL_GPL(sdio_signal_irq); > static int sdio_irq_thread(void *_host) > { > struct mmc_host *host = _host; > - struct sched_param param = { .sched_priority = 1 }; > unsigned long period, idle_period; > int ret; > > - sched_setscheduler(current, SCHED_FIFO, ¶m); > + sched_set_fifo_low(current); > > /* > * We want to allow for SDIO cards to work even on non SDIO > >
| |