Messages in this thread | | | Date | Wed, 22 Apr 2020 16:26:56 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v2] arm64: add check_wx_pages debugfs for CHECK_WX |
| |
On Wed, Apr 22, 2020 at 03:35:27PM +0100, Mark Rutland wrote: > On Wed, Apr 22, 2020 at 12:35:58AM +0700, Phong Tran wrote: > > follow the suggestion from > > https://github.com/KSPP/linux/issues/35 > > > > Signed-off-by: Phong Tran <tranmanphong@gmail.com> > > --- > > Change since v1: > > - Update the Kconfig help text > > - Don't check the return value of debugfs_create_file() > > - Tested on QEMU aarch64 > > As on v1, I think that this should be generic across all architectures > with CONFIG_DEBUG_WX. Adding this only on arm64 under > CONFIG_PTDUMP_DEBUGFS (which does not generally imply a WX check) > doesn't seem right. > > Maybe we need a new ARCH_HAS_CHECK_WX config to make that simpler, but > that seems simple to me.
Agreed. When I asked about respinning, I assumed this would be done in generic code as you requested on the first version. Phong -- do you think you can take a look at that, please?
> Thanks, > Marm.
Wow, employee of the month!
Will
| |