Messages in this thread | | | Subject | Re: [PATCH v4 4/7] kernel.h: Split out min()/max() et al helpers | From | Joe Perches <> | Date | Wed, 22 Apr 2020 07:52:32 -0700 |
| |
On Wed, 2020-04-22 at 15:51 +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out min()/max() > et al helpers.
While adding organization into kernel.h by splitting out various bits into separate files is a fine idea, I believe removing the generic #include <linux/kernel.h> from various files and substituting the sub-includes is not a good idea.
> At the same time convert users in header and lib folder to use new header. > Though for time being include new header back to kernel.h to avoid twisted > indirected includes for existing users.
Yeah, that's the difficult bit and it could make using precompiled headers very cumbersome.
I'd rather make #include <linux/kernel.h>" _more_ common or even used as the mandatory first #include for all kernel .c files.
That would also ensure that common kernel facilities are not duplicated or have naming conflicts with other files.
| |