Messages in this thread | | | From | Shiju Jose <> | Subject | RE: [RESEND PATCH v7 4/6] ACPI / APEI: Add callback for ARM HW errors to the GHES notifier | Date | Tue, 21 Apr 2020 15:18:04 +0000 |
| |
Hi Dan,
>-----Original Message----- >From: Dan Carpenter [mailto:dan.carpenter@oracle.com] >Sent: 21 April 2020 15:14 >To: Shiju Jose <shiju.jose@huawei.com> >Cc: linux-acpi@vger.kernel.org; linux-pci@vger.kernel.org; linux- >kernel@vger.kernel.org; rjw@rjwysocki.net; bp@alien8.de; >james.morse@arm.com; helgaas@kernel.org; lenb@kernel.org; >tony.luck@intel.com; gregkh@linuxfoundation.org; >zhangliguang@linux.alibaba.com; tglx@linutronix.de; Linuxarm ><linuxarm@huawei.com>; Jonathan Cameron ><jonathan.cameron@huawei.com>; tanxiaofei <tanxiaofei@huawei.com>; >yangyicong <yangyicong@huawei.com> >Subject: Re: [RESEND PATCH v7 4/6] ACPI / APEI: Add callback for ARM HW >errors to the GHES notifier > >On Tue, Apr 21, 2020 at 02:21:34PM +0100, Shiju Jose wrote: >> static BLOCKING_NOTIFIER_HEAD(ghes_event_notify_list); >> @@ -670,12 +692,7 @@ static void ghes_do_proc(struct ghes *ghes, >> pr_warn(GHES_PFX "ghes event queue full\n"); >> break; >> } >> - >> - if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { >> - struct cper_sec_proc_arm *err = >acpi_hest_get_payload(gdata); >> - >> - log_arm_hw_error(err); >> - } else { >> + { >> void *err = acpi_hest_get_payload(gdata); > >This is ugly. Just move the "void *err;" declaration to the top of the function >so we can delete this block. Ok. I will change. > >> >> log_non_standard_event(sec_type, fru_id, fru_text, >> -- > >regards, >dan carpenter
Thanks, Shiju
| |