Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 21 Apr 2020 16:04:54 +0200 | Subject | Re: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF |
| |
On Thu, 9 Apr 2020 at 08:44, Stephen Boyd <sboyd@kernel.org> wrote: > > Making COMMON_CLK a visible option causes the sparc allyesconfig to fail > to build like so: > > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove': > meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy' > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe': > meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create' > sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy' > > This is because the implementation of of_platform_device_destroy() is > inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c. > This driver already depends on OF being enabled, so let's tighten that > constrain a little more so that it depends on OF_ADDRESS instead. This > way we won't try to build this driver on platforms that don't have this > function. > > Reported-by: kbuild test robot <lkp@intel.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
I don't have the complete picture here, can I just apply this a fix to my mmc tree?
Kind regards Uffe
> --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 3a5089f0332c..31b2a8826b30 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -409,7 +409,7 @@ config MMC_MESON_MX_SDIO > tristate "Amlogic Meson6/Meson8/Meson8b SD/MMC Host Controller support" > depends on ARCH_MESON || COMPILE_TEST > depends on COMMON_CLK > - depends on OF > + depends on OF_ADDRESS > help > This selects support for the SD/MMC Host Controller on > Amlogic Meson6, Meson8 and Meson8b SoCs. > -- > Sent by a computer, using git, on the internet >
| |