lkml.org 
[lkml]   [2020]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/8] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression
On Mon, Apr 20, 2020 at 12:21:24PM +0200, Neil Armstrong wrote:
> On 17/04/2020 20:14, Daniel Vetter wrote:
> > On Fri, Apr 17, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> On 17/04/2020 17:07, Daniel Vetter wrote:
>
> [...]
>
> >
> > Yup there's a number of parametried modifiers. As long as the stuff
> > you get from a DRM_FORMAT_MOD_ ... macro is a full modifier with
> > everything it should be all fine.
>
> Would something like that be ok ?
>
> #define __fourcc_mod_amlogic_layout_mask 0xf
> #define __fourcc_mod_amlogic_options_shift 8
> #define __fourcc_mod_amlogic_options_mask 0xf
>
> #define DRM_FORMAT_MOD_AMLOGIC_FBC(__layout, __options) \
> fourcc_mod_code(AMLOGIC, \
> ((__layout) & __fourcc_mod_amlogic_layout_mask) | \
> ((options) & __fourcc_mod_amlogic_options_mask \
> << __fourcc_mod_amlogic_options_shift))
>
> /* Amlogic FBC Layouts */
>
> /* bla */
> #define AMLOGIC_FBC_LAYOUT_BASIC (1ULL)
>
> /* bla */
> #define AMLOGIC_FBC_LAYOUT_SCATTER (2ULL)
>
> /* Amlogic FBC Layout Options Bit Mask */
>
> /* bla */
> #define AMLOGIC_FBC_OPTION_MEM_SAVING (1ULL << 0)

lgtm.
-Daniel

>
> Neil
>
> > -Daniel
> >
> >> Neil
> >>
> >>> -Daniel
> >>>
> >>>> +
> >>>> #if defined(__cplusplus)
> >>>> }
> >>>> #endif
> >>>> --
> >>>> 2.22.0
> >>>>
> >>>
> >>
> >> _______________________________________________
> >> dri-devel mailing list
> >> dri-devel@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2020-04-21 14:17    [W:0.084 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site