lkml.org 
[lkml]   [2020]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net] vsock/virtio: postpone packet delivery to monitoring devices
    Date
    We delivering packets to monitoring devices, before to check if
    the virtqueue has enough space.

    If the virtqueue is full, the transmitting packet is queued up
    and it will be sent in the next iteration. This causes the same
    packet to be delivered multiple times to monitoring devices.

    This patch fixes this issue, postponing the packet delivery
    to monitoring devices, only when it is properly queued in the
    virqueue.

    Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks")
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    ---
    net/vmw_vsock/virtio_transport.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
    index dfbaf6bd8b1c..d8db837a96fe 100644
    --- a/net/vmw_vsock/virtio_transport.c
    +++ b/net/vmw_vsock/virtio_transport.c
    @@ -115,8 +115,6 @@ virtio_transport_send_pkt_work(struct work_struct *work)
    list_del_init(&pkt->list);
    spin_unlock_bh(&vsock->send_pkt_list_lock);

    - virtio_transport_deliver_tap_pkt(pkt);
    -
    reply = pkt->reply;

    sg_init_one(&hdr, &pkt->hdr, sizeof(pkt->hdr));
    @@ -137,6 +135,11 @@ virtio_transport_send_pkt_work(struct work_struct *work)
    break;
    }

    + /* Deliver to monitoring devices all correctly transmitted
    + * packets.
    + */
    + virtio_transport_deliver_tap_pkt(pkt);
    +
    if (reply) {
    struct virtqueue *rx_vq = vsock->vqs[VSOCK_VQ_RX];
    int val;
    --
    2.25.3
    \
     
     \ /
      Last update: 2020-04-21 11:26    [W:2.516 / U:1.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site