Messages in this thread Patch in this message | | | Subject | [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue | From | 赵军奎 <> | Date | Tue, 21 Apr 2020 17:08:44 +0800 (GMT+08:00) |
| |
From: Bernard Zhao <bernard@vivo.com> Date: 2020-04-21 10:07:50 To: Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,"David (ChunMing) Zhou" <David1.Zhou@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Lyude Paul <lyude@redhat.com>,Sam Ravnborg <sam@ravnborg.org>,Bernard Zhao <bernard@vivo.com>,"José Roberto de Souza" <jose.souza@intel.com>,Andrzej Pietrasiewicz <andrzej.p@collabora.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com Subject: [PATCH v2] amdgpu: fixes error branch not return errno issue>The "if(!encoder)" branch return the same value 0 of the success >branch, maybe return -EINVAL is more better. > >Signed-off-by: Bernard Zhao <bernard@vivo.com> > >--- >Changes since V1: >* commit message improve >--- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >index f355d9a..1f8c6b4 100644 >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > > if (!amdgpu_encoder->enc_priv) >- return 0; >+ return -EINVAL; > > dig = amdgpu_encoder->enc_priv; > new_coherent_mode = val ? true : false; >@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > >@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > >@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > >@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > >@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, > /* need to find digital encoder on connector */ > encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS); > if (!encoder) >- return 0; >+ return -EINVAL; > > amdgpu_encoder = to_amdgpu_encoder(encoder); > >-- >2.7.4
>
add Markus.Elfring in mail list Regards, Bernard
| |