lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/etnaviv: Omit superfluous error message in etnaviv_gpu_platform_probe()
Am Sa., 18. Apr. 2020 um 12:01 Uhr schrieb Tang Bin
<tangbin@cmss.chinamobile.com>:
>
> In the function etnaviv_gpu_platform_probe(), when get irq failed,
> the function platform_get_irq() logs an error message, so remove
> redundant message here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>

> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index a31eeff2b..6dbe0c45b 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
>
> /* Get Interrupt: */
> gpu->irq = platform_get_irq(pdev, 0);
> - if (gpu->irq < 0) {
> - dev_err(dev, "failed to get irq: %d\n", gpu->irq);
> + if (gpu->irq < 0)
> return gpu->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> dev_name(gpu->dev), gpu);
> --
> 2.20.1.windows.1
>
>
>


--
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy

\
 
 \ /
  Last update: 2020-04-20 17:10    [W:0.033 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site