lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 38/65] ASoC: Intel: mrfld: fix incorrect check on p->sink
    Date
    From: Colin Ian King <colin.king@canonical.com>

    commit f5e056e1e46fcbb5f74ce560792aeb7d57ce79e6 upstream.

    The check on p->sink looks bogus, I believe it should be p->source
    since the following code blocks are related to p->source. Fix
    this by replacing p->sink with p->source.

    Fixes: 24c8d14192cc ("ASoC: Intel: mrfld: add DSP core controls")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Addresses-Coverity: ("Copy-paste error")
    Link: https://lore.kernel.org/r/20191119113640.166940-1-colin.king@canonical.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/intel/atom/sst-atom-controls.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/soc/intel/atom/sst-atom-controls.c
    +++ b/sound/soc/intel/atom/sst-atom-controls.c
    @@ -1333,7 +1333,7 @@ int sst_send_pipe_gains(struct snd_soc_d
    dai->capture_widget->name);
    w = dai->capture_widget;
    snd_soc_dapm_widget_for_each_source_path(w, p) {
    - if (p->connected && !p->connected(w, p->sink))
    + if (p->connected && !p->connected(w, p->source))
    continue;

    if (p->connect && p->source->power &&

    \
     
     \ /
      Last update: 2020-04-20 14:41    [W:4.821 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site