lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd
Em Mon, Apr 20, 2020 at 10:48:47AM +0200, Jiri Olsa escreveu:
> On Fri, Apr 17, 2020 at 04:23:26PM +0300, Tommi Rantala wrote:
> > Do not bother with close() if fd is not valid, just to silence valgrind:
> >
> > $ valgrind ./perf script
> > ==59169== Memcheck, a memory error detector
> > ==59169== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
> > ==59169== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
> > ==59169== Command: ./perf script
> > ==59169==
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> >
> > Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks, applied,

- Arnaldo

\
 
 \ /
  Last update: 2020-04-20 14:06    [W:0.084 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site