lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 4/6] tlb: mmu_gather: add tlb_set_*_range APIs
    On Fri, Apr 03, 2020 at 05:00:46PM +0800, Zhenyu Ye wrote:
    > From: "Peter Zijlstra (Intel)" <peterz@infradead.org>
    >
    > tlb_set_{pte|pmd|pud|p4d}_range() adjust the tlb->start and
    > tlb->end, then set corresponding cleared_*.
    >
    > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    > Signed-off-by: Zhenyu Ye <yezhenyu2@huawei.com>
    > ---
    > include/asm-generic/tlb.h | 55 ++++++++++++++++++++++++++++-----------
    > 1 file changed, 40 insertions(+), 15 deletions(-)
    >
    > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
    > index f391f6b500b4..ee91310a65c6 100644
    > --- a/include/asm-generic/tlb.h
    > +++ b/include/asm-generic/tlb.h
    > @@ -511,6 +511,38 @@ static inline void tlb_end_vma(struct mmu_gather *tlb, struct vm_area_struct *vm
    > }
    > #endif
    >
    > +/*
    > + * tlb_set_{pte|pmd|pud|p4d}_range() adjust the tlb->start and tlb->end,
    > + * and set corresponding cleared_*.
    > + */
    > +static inline void tlb_set_pte_range(struct mmu_gather *tlb,
    > + unsigned long address, unsigned long size)
    > +{
    > + __tlb_adjust_range(tlb, address, size);
    > + tlb->cleared_ptes = 1;
    > +}
    > +
    > +static inline void tlb_set_pmd_range(struct mmu_gather *tlb,
    > + unsigned long address, unsigned long size)
    > +{
    > + __tlb_adjust_range(tlb, address, size);
    > + tlb->cleared_pmds = 1;
    > +}
    > +
    > +static inline void tlb_set_pud_range(struct mmu_gather *tlb,
    > + unsigned long address, unsigned long size)
    > +{
    > + __tlb_adjust_range(tlb, address, size);
    > + tlb->cleared_puds = 1;
    > +}
    > +
    > +static inline void tlb_set_p4d_range(struct mmu_gather *tlb,
    > + unsigned long address, unsigned long size)
    > +{
    > + __tlb_adjust_range(tlb, address, size);
    > + tlb->cleared_p4ds = 1;
    > +}

    Uhm.. when I wrote that patch they were called tlb_flush_p*_range():

    https://lkml.kernel.org/r/20200401122004.GE20713@hirez.programming.kicks-ass.net

    Your current naming makes no sense what so ever, we do not "set" the
    range.

    \
     
     \ /
      Last update: 2020-04-20 13:49    [W:4.103 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site