Messages in this thread | | | From | Michal Kalderon <> | Subject | RE: [EXT] [PATCH] net: qed: Remove unneeded cast from memory allocation | Date | Mon, 20 Apr 2020 05:11:54 +0000 |
| |
> From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com> > Sent: Sunday, April 19, 2020 7:29 PM > > ---------------------------------------------------------------------- > Remove casting the values returned by memory allocation function. > > Coccinelle emits WARNING: casting value returned by memory allocation > function to struct pointer is useless. > > This issue was detected by using the Coccinelle. > > Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com> > --- > drivers/net/ethernet/qlogic/qed/qed_roce.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c > b/drivers/net/ethernet/qlogic/qed/qed_roce.c > index 37e70562a964..475b89903f46 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_roce.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c > @@ -736,9 +736,9 @@ static int qed_roce_sp_destroy_qp_responder(struct > qed_hwfn *p_hwfn, > > p_ramrod = &p_ent->ramrod.roce_destroy_qp_resp; > > - p_ramrod_res = (struct roce_destroy_qp_resp_output_params *) > - dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, > sizeof(*p_ramrod_res), > - &ramrod_res_phys, GFP_KERNEL); > + p_ramrod_res = dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, > + sizeof(*p_ramrod_res), > + &ramrod_res_phys, GFP_KERNEL); > > if (!p_ramrod_res) { > rc = -ENOMEM; > @@ -872,10 +872,10 @@ int qed_roce_query_qp(struct qed_hwfn > *p_hwfn, > } > > /* Send a query responder ramrod to FW to get RQ-PSN and state */ > - p_resp_ramrod_res = (struct roce_query_qp_resp_output_params > *) > - dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, > - sizeof(*p_resp_ramrod_res), > - &resp_ramrod_res_phys, GFP_KERNEL); > + p_resp_ramrod_res = > + dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, > + sizeof(*p_resp_ramrod_res), > + &resp_ramrod_res_phys, GFP_KERNEL); > if (!p_resp_ramrod_res) { > DP_NOTICE(p_hwfn, > "qed query qp failed: cannot allocate memory > (ramrod)\n"); @@ -920,8 +920,7 @@ int qed_roce_query_qp(struct > qed_hwfn *p_hwfn, > } > > /* Send a query requester ramrod to FW to get SQ-PSN and state */ > - p_req_ramrod_res = (struct roce_query_qp_req_output_params *) > - dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, > + p_req_ramrod_res = dma_alloc_coherent(&p_hwfn->cdev->pdev- > >dev, > sizeof(*p_req_ramrod_res), > &req_ramrod_res_phys, > GFP_KERNEL); > -- > 2.17.1
Thanks,
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
| |