Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 20 Apr 2020 11:27:56 +0200 | Subject | Re: [PATCH 24/29] mm: remove __vmalloc_node_flags_caller |
| |
Hi Christoph,
On Tue, Apr 14, 2020 at 3:21 PM Christoph Hellwig <hch@lst.de> wrote: > Just use __vmalloc_node instead which gets and extra argument. To be > able to to use __vmalloc_node in all caller make it available outside > of vmalloc and implement it in nommu.c. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
One more nommu failure below...
> --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,8 +150,8 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > -void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, > - void *caller) > +void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, > + int node, const void *caller) > { > return __vmalloc(size, flags);
On Mon, Apr 20, 2020 at 10:39 AM <noreply@ellerman.id.au> wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:164:25: error: 'flags' undeclared (first use in this function); did you mean 'class'?
"return __vmalloc(size, gfp_mask);"
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |