lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
    On Mon, 20 Apr 2020 01:20:40 +0300
    Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

    > On Sat, Apr 18, 2020 at 10:55:33AM +0200, Boris Brezillon wrote:
    > > On Fri, 17 Apr 2020 16:21:47 +0800
    > > "Ramuthevar,Vadivel MuruganX"
    > > <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
    > >
    > > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
    >
    > > > +static const struct of_device_id lgm_nand_match[] = {
    > > > + { .compatible = "intel,lgm-nand", },
    > > > + {}
    > > > +};
    > > > +MODULE_DEVICE_TABLE(of, lgm_nand_match);
    > >
    > > You probably have a missing "depends on OF" in your Kconfig.
    >
    > Since it's using device property API, dependency is not needed.
    >

    There's no compile-time dependency, but this driver will be pretty
    useless if all its users have the NAND controller node defined in their
    DT and CONFIG_OF is not enabled. I guess the OF option is selected by
    arches, so explicitly depending on OF is only relevant if you change
    the dependency rules as suggested in my other reply.

    \
     
     \ /
      Last update: 2020-04-20 11:19    [W:2.650 / U:1.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site