lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: qlge: replace deprecated apis pci_dma_*
On Sun, Apr 19, 2020 at 10:08:16AM +0900, Sidong Yang wrote:
> direction =
> - (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? PCI_DMA_TODEVICE :
> - PCI_DMA_FROMDEVICE;
> + (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? DMA_TO_DEVICE :
> + DMA_FROM_DEVICE;

Can you unobsfucate this while you are at it?

if (bit & (CFG_LRQ | CFG_LR | CFG_LCQ))
direction = DMA_TO_DEVICE;
else
direction = DMA_FROM_DEVICE;

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2020-04-20 10:49    [W:0.061 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site