Messages in this thread | | | Date | Tue, 21 Apr 2020 00:32:29 +0200 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: Fix refcnt leak in btrfs_recover_relocation |
| |
On Mon, Apr 20, 2020 at 06:35:56PM +0100, Filipe Manana wrote: > On Mon, Apr 20, 2020 at 6:34 PM Filipe Manana <fdmanana@gmail.com> wrote: > > > > On Mon, Apr 20, 2020 at 6:50 AM Xiyu Yang <xiyuyang19@fudan.edu.cn> wrote: > > > > > > btrfs_recover_relocation() invokes btrfs_join_transaction(), which joins > > > a btrfs_trans_handle object into transactions and returns a reference of > > > it with increased refcount to "trans". > > > > > > When btrfs_recover_relocation() returns, "trans" becomes invalid, so the > > > refcount should be decreased to keep refcount balanced. > > > > > > The reference counting issue happens in one exception handling path of > > > btrfs_recover_relocation(). When read_fs_root() failed, the refcnt > > > increased by btrfs_join_transaction() is not decreased, causing a refcnt > > > leak. > > > > > > Fix this issue by calling btrfs_end_transaction() on this error path > > > when read_fs_root() failed. > > > > > > Fixes: 79787eaab461 ("btrfs: replace many BUG_ONs with proper error > > > handling") > > > Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> > > > Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> > > > > Reviewed-by: Filipe Manana <fdmanana@suse.com> > > > > Looks good, thanks. > > Btw, the subject could be more clear. > Instead of > > "btrfs: Fix refcnt leak in btrfs_recover_relocation" > > something like > > "btrfs: fix transaction leak in ..." > > David can probably fixup that when he picks the patch.
Yes, thanks, simple fixups are fine.
| |