Messages in this thread | | | From | Vineeth Remanan Pillai <> | Date | Mon, 20 Apr 2020 18:26:34 -0400 | Subject | Re: [PATCH updated] sched/fair: core wide cfs task priority comparison |
| |
On Mon, Apr 20, 2020 at 4:08 AM Aaron Lu <aaron.lwe@gmail.com> wrote: > > On Fri, Apr 17, 2020 at 05:40:45PM +0800, Aaron Lu wrote:
> The adjust is only needed when core scheduling is enabled while I > mistakenly called it on both enable and disable. And I come to think > normalize is a better name than adjust. > I guess we would also need to update the min_vruntime of the sibling to match the rq->core->min_vruntime on coresched disable. Otherwise a new enqueue on root cfs of the sibling would inherit the very old min_vruntime before coresched enable and thus would starve all the already queued tasks until the newly enqueued se's vruntime catches up.
Other than that, I think the patch looks good. We haven't tested it yet. Will do a round of testing and let you know soon.
Thanks, Vineeth
| |