lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] dt-bindings: regulator: Add document bindings for max77826
On Mon, Apr 13, 2020 at 07:44:39PM +0300, Iskren Chernev wrote:
> Add device tree binding information for max77826 regulator driver.
> Example bindings for max77826 are added.
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
> .../bindings/regulator/maxim,max77826.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77826.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max77826.yaml b/Documentation/devicetree/bindings/regulator/maxim,max77826.yaml
> new file mode 100644
> index 000000000000..3cd449a746b0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max77826.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/maxim,max77826.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX77826 PMIC
> +
> +maintainers:
> + - Iskren Chernev <iskren.chernev@gmail.com>
> +
> +properties:
> + $nodename:
> + pattern: "pmic@[0-9a-f]{1,2}"
> + compatible:
> + enum:
> + - maxim,max77826-regulator
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + type: object
> + allOf:
> + - $ref: regulator.yaml#
> + description: |
> + list of regulators provided by this controller, must be named
> + after their hardware counterparts LDO[1-15], BUCK and BUCKBOOST
> +
> + patternProperties:
> + "^LDO([1-9]|1[0-5])$":
> + type: object
> + allOf:
> + - $ref: regulator.yaml#
> +
> + "^BUCK|BUCKBOOST$":
> + type: object
> + allOf:
> + - $ref: regulator.yaml#
> +
> + additionalProperties: false

You are defining a property called 'additionalProperties'. This one
should be dropped because additionalProperties doesn't work with a $ref.

> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - regulators
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@69 {
> + compatible = "maxim,max77826-regulator";
> + reg = <0x69>;
> +
> + regulators {
> + LDO2 {
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <650000>;
> + regulator-max-microvolt = <3587500>;
> + };
> + };
> + };
> + };
> +...
> --
> 2.26.0
>

\
 
 \ /
  Last update: 2020-04-20 22:55    [W:0.091 / U:4.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site