Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH 1/2][v2] sched: Make newidle_balance() static again | Date | Mon, 20 Apr 2020 18:43:37 +0100 |
| |
On 20/04/20 16:01, Chen Yu wrote: > After Commit 6e2df0581f56 ("sched: Fix pick_next_task() vs 'change' > pattern race"), there is no need to expose newidle_balance() as it > is only used within fair.c file. Change this function back to static again. > > No functional change. >
That derelict 'idle_balance()' is a funny one.
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
> Suggested-by: Peter Zijlstra <peterz@infradead.org> > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Chen Yu <yu.c.chen@intel.com> > --- > v2: Rename the remaining idle_balance() to newidle_balance() > to fix an compile error when CONFIG_SMP is not set.
| |