Messages in this thread | | | Subject | Re: [PATCHv3 24/50] openrisc: Add show_stack_loglvl() | From | Dmitry Safonov <> | Date | Mon, 20 Apr 2020 18:06:26 +0100 |
| |
On 4/19/20 9:57 PM, Stafford Horne wrote: > On Sat, Apr 18, 2020 at 09:19:18PM +0100, Dmitry Safonov wrote: >> Currently, the log-level of show_stack() depends on a platform >> realization. It creates situations where the headers are printed with > > Instead of realization I would say "Implementation". > >> lower log level or higher than the stacktrace (depending on >> a platform or user). >> >> Furthermore, it forces the logic decision from user to an architecture >> side. In result, some users as sysrq/kdb/etc are doing tricks with >> temporary rising console_loglevel while printing their messages. >> And in result it not only may print unwanted messages from other CPUs, >> but also omit printing at all in the unlucky case where the printk() >> was deferred. >> >> Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems >> an easier approach than introducing more printk buffers. >> Also, it will consolidate printings with headers. >> >> Introduce show_stack_loglvl(), that eventually will substitute >> show_stack(). > > Will you do the work to replace show_stack(), when is that planned?
In the patch 50/50 from the series: https://lore.kernel.org/lkml/20200418201944.482088-51-dima@arista.com/
> > Other than that small comment this looks fine. > > Acked-by: Stafford Horne <shorne@gmail.com> Thank you, Dmitry
| |