Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 20 Apr 2020 09:17:15 +0200 | Subject | Re: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch fall-through |
| |
On Fri, Mar 27, 2020 at 12:25 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: allmodconfig m68k): > > arch/m68k/amiga/config.c: In function ‘amiga_identify’: > ./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=] > #define AMIGAHW_SET(name) (amiga_hw_present.name = 1) > ~~~~~~~~~~~~~~~~~~~~~~~^~~~ > arch/m68k/amiga/config.c:223:3: note: in expansion of macro ‘AMIGAHW_SET’ > AMIGAHW_SET(PCMCIA); > ^~~~~~~~~~~ > arch/m68k/amiga/config.c:224:2: note: here > case AMI_500: > ^~~~ > > Replace the existing /* fall through */ comments and fix the issue above > by using the new pseudo-keyword fallthrough; > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> i.e. will queue in the m68k for-v5.8 branch.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |