Messages in this thread | | | From | Logan Gunthorpe <> | Date | Mon, 20 Apr 2020 10:44:23 -0600 | Subject | Re: [PATCH] x86/mm: fix compilation error for unknown type name pgprot_t |
| |
On 2020-04-20 2:22 a.m., Abhishek Sahu wrote: > commit 30796e18c299 ("x86/mm: introduce __set_memory_prot()") > added the function __set_memory_prot() which uses pgprot_t in > function prototype. The currently included header files in > <arch/x86/include/asm/set_memory.h> do not include type name > pgprot_t. The pgprot_t is defined in <asm/pgtable_types.h>. > > Fixes: 30796e18c299 ("x86/mm: introduce __set_memory_prot()") > Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
I assume this is only hit with a specific driver or something that includes set_memory.h without including pgtable_types.h before hand.
It certainly compiles fine for me and the kbuild robot has had lots of time to test it with random configs.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Thanks,
Logan
| |