Messages in this thread | | | Date | Thu, 2 Apr 2020 14:49:46 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v8 6/7] tools/perf: Enable Hz/hz prinitg for --metric-only option |
| |
On Thu, Apr 02, 2020 at 02:03:39AM +0530, Kajol Jain wrote: > Commit 54b5091606c18 ("perf stat: Implement --metric-only mode") > added function 'valid_only_metric()' which drops "Hz" or "hz", > if it is part of "ScaleUnit". This patch enable it since hv_24x7 > supports couple of frequency events. > > Signed-off-by: Kajol Jain <kjain@linux.ibm.com> > --- > tools/perf/util/stat-display.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 9e757d18d713..679aaa655824 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -237,8 +237,6 @@ static bool valid_only_metric(const char *unit) > if (!unit) > return false; > if (strstr(unit, "/sec") || > - strstr(unit, "hz") || > - strstr(unit, "Hz") ||
will this change output of --metric-only for some setups then?
Andi, are you ok with this?
other than this, the patchset looks ok to me
thanks, jirka
> strstr(unit, "CPUs utilized")) > return false; > return true; > -- > 2.21.0 >
| |