Messages in this thread | | | Date | Thu, 2 Apr 2020 11:16:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 4/5] staging: rtl8712: fix multiline derefernce warning |
| |
Hi Aiman,
On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote: > On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote: > > so these would be > > ether_addr_copy(pwlanhdr->addr2, pattr->src); > > and pwlanhdr isn't a particularly valuable name > for an automatic either. It's hungarian like. >
"Hungarian like" means it starts with a "p".
https://en.wikipedia.org/wiki/Hungarian_notation
It's against the rules of kernel style.
regards, dan carpenter
| |