Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 2 Apr 2020 15:56:14 -0700 | Subject | Re: [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string |
| |
Hi,
On Thu, Apr 2, 2020 at 3:37 PM John Stultz <john.stultz@linaro.org> wrote: > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > as a generic compat string. However the change also removed > the "qcom,sdm845-qusb2-phy" compat string, which is documented > in the binding and already in use. > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > which allows the driver to continue to work with existing dts > entries such as found on the db845c. > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Doug Anderson <dianders@chromium.org> > Cc: Manu Gautam <mgautam@codeaurora.org> > Cc: Sandeep Maheswaram <sanm@codeaurora.org> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > Reported-by: YongQin Liu <yongqin.liu@linaro.org> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ > 1 file changed, 3 insertions(+)
Do you have an out-of-tree dts file? If not, I'd prefer that the fix was for this patch to land instead:
https://lore.kernel.org/r/1583747589-17267-9-git-send-email-sanm@codeaurora.org
While we can land your patch if someone needs it for supporting an out-of-tree dts, it gives people supporting future SoCs the idea that they need to add themselves to this table too. That's now discouraged unless there's a specific quirk that needs to be handled just for this SoC.
-Doug
| |