Messages in this thread | | | Subject | Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu connector set property() | From | 赵军奎 <> | Date | Mon, 20 Apr 2020 08:56:16 +0800 (GMT+08:00) |
| |
发件人:Markus Elfring <Markus.Elfring@web.de> 发送日期:2020-04-19 17:34:47 收件人:Bernard Zhao <bernard@vivo.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,Chunming Zhou <David1.Zhou@amd.com> 抄送人:Andrzej Pietrasiewicz <andrzej.p@collabora.com>,Daniel Vetter <daniel@ffwll.ch>,David Airlie <airlied@linux.ie>,Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,"José Roberto de Souza" <jose.souza@intel.com>,Lyude Paul <lyude@redhat.com>,Neil Armstrong <narmstrong@baylibre.com>,Sam Ravnborg <sam@ravnborg.org>,linux-kernel@vger.kernel.org,opensource.kernel@vivo.com 主题:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success >> branch, maybe return -EINVAL is more better. > >I suggest to improve the commit message.
Sure.
> >* Would you like to adjust the patch subject? > >* How do you think about to add the tag “Fixes” > because of adjustments for the exception handling?
This is a good idea, the code will be more in line with the Linux specifications. I will adjust this patch commit message and modify the code. I will submit it again.
> >Regards, >Markus
| |