| Subject | Re: [PATCH v2 05/10] blktrace: upgrade warns to BUG_ON() on unexpected circmunstances | From | Bart Van Assche <> | Date | Sun, 19 Apr 2020 15:50:13 -0700 |
| |
On 4/19/20 12:45 PM, Luis Chamberlain wrote: > @@ -498,10 +498,7 @@ static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup *buts, > struct dentry *dir = NULL; > > /* This can only happen if we have a bug on our lower layers */ > - if (!q->kobj.parent) { > - pr_warn("%s: request_queue parent is gone\n", buts->name); > - return NULL; > - } > + BUG_ON(!q->kobj.parent);
Does the following quote from Linus also apply to this patch: "there is NO F*CKING EXCUSE to knowingly kill the kernel." See also https://lkml.org/lkml/2016/10/4/1.
Thanks,
Bart.
|