lkml.org 
[lkml]   [2020]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether_tuple()
From
From: Huazhong Tan <tanhuazhong@huawei.com>
Date: Sat, 18 Apr 2020 14:47:00 +0800

> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
> + struct ethtool_rx_flow_spec *fs,
> + u32 *unused_tuple)
> +{
> + int ret = 0;

There is no code path that uses 'ret' without it first being
assigned. If I let this code in, then someone is going to
submit a fixup patch removing the initialization.

\
 
 \ /
  Last update: 2020-04-19 05:18    [W:0.063 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site