Messages in this thread Patch in this message | | | From | Tiezhu Yang <> | Subject | [PATCH 3/4] kmod: Return directly if module name is empty in request_module() | Date | Sat, 18 Apr 2020 13:19:59 +0800 |
| |
If module name is empty, it is better to return directly at the beginning of request_module() without doing the needless call_modprobe() operation.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- kernel/kmod.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/kernel/kmod.c b/kernel/kmod.c index 3cd075c..5851444 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c @@ -28,6 +28,8 @@ #include <trace/events/module.h> +#define MODULE_NOT_FOUND 256 + /* * Assuming: * @@ -144,6 +146,9 @@ int __request_module(bool wait, const char *fmt, ...) if (ret >= MODULE_NAME_LEN) return -ENAMETOOLONG; + if (strlen(module_name) == 0) + return MODULE_NOT_FOUND; + ret = security_kernel_module_request(module_name); if (ret) return ret; -- 2.1.0
| |