Messages in this thread | | | From | Arnd Bergmann <> | Date | Sat, 18 Apr 2020 21:11:06 +0200 | Subject | Re: [PATCH v6,4/4] drivers: misc: new driver sram_uapi for user level SRAM access |
| |
On Sat, Apr 18, 2020 at 6:22 PM Wang Wenhu <wenhu.wang@vivo.com> wrote: > +#define DRIVER_NAME "sram_uapi" > + > +#define SRAM_UAPI_IOCTL_SET_SRAM_TYPE 0 > +#define SRAM_UAPI_IOCTL_ALLOC 1 > +#define SRAM_UAPI_IOCTL_FREE 2 > + > +struct res_info { > + u32 offset; > + u32 size; > +};
This is of course not a proper ioctl interface at all, please see Documentation/driver-api/ioctl.rst for how to define the numbers in a uapi header file.
The offset/size arguments should probably be 64 bit wide.
Arnd
| |