Messages in this thread | | | Date | Sat, 18 Apr 2020 16:46:06 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v4 1/3] iio: documentation ltc2632_chip_info add num_channels |
| |
On Thu, 16 Apr 2020 09:20:09 +0800 Chris Ruehl <chris.ruehl@gtsys.com.hk> wrote:
> The documentation for ltc_2632_chip_info missed the desciption for the > num_channels. This trivial patch adds it. > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Please make sure to pick up tags from earlier versions. Uwe gave one to v3 + added a fixes tag to make it explicit which commit introduced the field but didn't document it.
I'm in two minds on whether to leave that in the commit when I take it as the AI bot may well pick the patch up and backport it which seems a bit pointless if harmless!
Still if you respin please add it and I can make up my mind then. In meantime the series needs DT review.
> --- > v4: > Fix commit text. > > drivers/iio/dac/ltc2632.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c > index 7adc91056aa1..2a84ea654645 100644 > --- a/drivers/iio/dac/ltc2632.c > +++ b/drivers/iio/dac/ltc2632.c > @@ -24,6 +24,7 @@ > /** > * struct ltc2632_chip_info - chip specific information > * @channels: channel spec for the DAC > + * @num_channels: DAC channel count of the chip > * @vref_mv: internal reference voltage > */ > struct ltc2632_chip_info {
| |