Messages in this thread | | | Subject | Re: [PATCH] iommu/qcom:fix local_base status check | From | Tang Bin <> | Date | Sat, 18 Apr 2020 21:08:02 +0800 |
| |
On 2020/4/18 19:54, Joerg Roedel wrote: > On Thu, Apr 16, 2020 at 02:42:23PM +0800, Tang Bin wrote: >> The function qcom_iommu_device_probe() does not perform sufficient >> error checking after executing devm_ioremap_resource(), which can result in >> crashes if a critical error path is encountered. >> >> Fixes: 0ae349a0("iommu/qcom: Add qcom_iommu") > Yes, that sounds better. Please use it for the commit message and also > add the Fixes line and resubmit the fix to me. > Please make the fixes line: > > Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") > > So that the commit-id is 12 characters long and a space between it and > the subject.
Got it, thanks for your instruction.
Tang Bin
> >
| |