lkml.org 
[lkml]   [2020]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] remoteproc: qcom_q6v5_mss: fix a bug in q6v5_probe()
From
Date
On 4/3/20 12:50 PM, Alex Elder wrote:
> If looking up the DT "firmware-name" property fails in q6v6_probe(),
> the function returns without freeing the remoteproc structure
> that has been allocated. Fix this by jumping to the free_rproc
> label, which takes care of this.
>

Please add the Fixes: line.

> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index ce49c3236ff7..60cdf699ea80 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1675,7 +1675,7 @@ static int q6v5_probe(struct platform_device *pdev)
> ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
> 1, &qproc->hexagon_mdt_image);
> if (ret < 0 && ret != -EINVAL)
> - return ret;
> + goto free_rproc;
>
> platform_set_drvdata(pdev, qproc);
>
>

\
 
 \ /
  Last update: 2020-04-17 18:28    [W:0.108 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site