lkml.org 
[lkml]   [2020]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/16] perf intel-pt: Add support for synthesizing callchains for regular events
From
Date
On 16/04/20 6:14 pm, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 01, 2020 at 01:16:08PM +0300, Adrian Hunter escreveu:
>> Currently, callchains can be synthesized only for synthesized events.
>> Support also synthesizing callchains for regular events.
>
> This is super cool, I wonder if we shouldn't do it automatically or just
> adding a new type of callchains, i.e.:
>
> perf record --call-graph pt uname
>
> Should take care of all the details, i.e. do the extra steps below
> behind the scenes.
>
> Possibly even find out that the workload specified was built with
> -fomit-frame-pointers, that the hardware has Intel PT and do all behind
> the scenes for:
>
> perf record -g uname
>
> Alternatively we could take some less seemingly far fetched approach and
> make this configurable via:
>
> perf config call-graph.record-mode=pt
>
> What do you think?

Adding a --call-graph option sounds reasonable, and config to define default
callgraph options. But this was done at Andi Kleen's request, so he may
want to comment.

\
 
 \ /
  Last update: 2020-04-17 15:52    [W:0.199 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site