Messages in this thread | | | From | Baolin Wang <> | Date | Sat, 18 Apr 2020 09:52:58 +0800 | Subject | Re: [PATCH 2/2] soc: sprd: Add Spreadtrum special bits updating support |
| |
On Fri, Apr 17, 2020 at 11:03 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Fri, Apr 17, 2020 at 4:10 PM Baolin Wang <baolin.wang7@gmail.com> wrote: > > On Fri, Apr 17, 2020 at 9:39 PM Arnd Bergmann <arnd@arndb.de> wrote: > > > On Fri, Apr 17, 2020 at 4:14 AM Baolin Wang <baolin.wang7@gmail.com> wrote: > > > > +static int sprd_syscon_init(void) > > > > +{ > > > > + syscon_register_phys_regmap_bus(&sprd_syscon_regmap); > > > > + > > > > + return 0; > > > > +} > > > > +core_initcall_sync(sprd_syscon_init); > > > > > > This no longer breaks at runtime based on the changes in the other > > > patch, but I still don't like how you have to manually load this module > > > on spreadtrum platforms. > > > > > > What I meant to suggest in my previous reply was to add the regmap_bus > > > instance into drivers/mfd/syscon.c itself. > > > > Sorry, I misunderstood your meaning before, but what you suggested > > will add some vendor-specific things into the common syscon driver, if > > other platforms have different update bits method, we will add another > > vendor-specific regmap bus into the syscon.c, which will make syscon.c > > more complicated. > > I think we can always deal with this once it gets too complex, as long > as the DT binding allows it. > > > But if you still prefer to add these vendor-specific things into the > > syscon.c, I will follow your suggestion in next version. Thanks. > > Yes, please do.
Sure. Thanks.
-- Baolin Wang
| |