lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 051/146] ALSA: hda: Add driver blacklist
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 3c6fd1f07ed03a04debbb9a9d782205f1ef5e2ab upstream.

    The recent AMD platform exposes an HD-audio bus but without any actual
    codecs, which is internally tied with a USB-audio device, supposedly.
    It results in "no codecs" error of HD-audio bus driver, and it's
    nothing but a waste of resources.

    This patch introduces a static blacklist table for skipping such a
    known bogus PCI SSID entry. As of writing this patch, the known SSIDs
    are:
    * 1043:874f - ASUS ROG Zenith II / Strix
    * 1462:cb59 - MSI TRX40 Creator
    * 1462:cb60 - MSI TRX40

    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206543
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200408140449.22319-2-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/hda_intel.c | 16 ++++++++++++++++
    1 file changed, 16 insertions(+)

    --- a/sound/pci/hda/hda_intel.c
    +++ b/sound/pci/hda/hda_intel.c
    @@ -2219,6 +2219,17 @@ static const struct hdac_io_ops pci_hda_
    .dma_free_pages = dma_free_pages,
    };

    +/* Blacklist for skipping the whole probe:
    + * some HD-audio PCI entries are exposed without any codecs, and such devices
    + * should be ignored from the beginning.
    + */
    +static const struct snd_pci_quirk driver_blacklist[] = {
    + SND_PCI_QUIRK(0x1043, 0x874f, "ASUS ROG Zenith II / Strix", 0),
    + SND_PCI_QUIRK(0x1462, 0xcb59, "MSI TRX40 Creator", 0),
    + SND_PCI_QUIRK(0x1462, 0xcb60, "MSI TRX40", 0),
    + {}
    +};
    +
    static const struct hda_controller_ops pci_hda_ops = {
    .disable_msi_reset_irq = disable_msi_reset_irq,
    .substream_alloc_pages = substream_alloc_pages,
    @@ -2238,6 +2249,11 @@ static int azx_probe(struct pci_dev *pci
    bool schedule_probe;
    int err;

    + if (snd_pci_quirk_lookup(pci, driver_blacklist)) {
    + dev_info(&pci->dev, "Skipping the blacklisted device\n");
    + return -ENODEV;
    + }
    +
    if (dev >= SNDRV_CARDS)
    return -ENODEV;
    if (!enable[dev]) {

    \
     
     \ /
      Last update: 2020-04-16 15:30    [W:4.049 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site