lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data


----- On 16 Apr, 2020, at 14:47, Mark Brown broonie@kernel.org wrote:

> On Thu, Apr 16, 2020 at 01:50:55PM +0200, Clément Leger wrote:
>> Hi Mark,
>
> Please don't top post, reply in line with needed context. This allows
> readers to readily follow the flow of conversation and understand what
> you are talking about and also helps ensure that everything in the
> discussion is being addressed.

Sorry, I'll take care of that.

>
>> Sorry, maybe the commit message was not clear enough but actually
>> these fields were not initialized so it does not break anything
>> (ie, the default values were always used).
>
> When you remove the definition of the struct and declaration of the
> variable pointing to it then the code won't compile.

Yes I know and I took care of that but there is probably a misunderstanding.
There is actually two structs with the same members (dw_chip_info and
chip_data). The first one (chip_info) if it exists, is copied into the
second (chip_data). First patch [1/2] removes the part of code that did
copy these fields. And then second patchs removes the usage of chip_data
fields. Please let me know if I missed something. I tried to recompile it
and there is no build breakage.

Clément

>
> > > This means that your first patch will break the build, to keep things

\
 
 \ /
  Last update: 2020-04-16 14:59    [W:0.072 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site