Messages in this thread | | | Subject | Re: [PATCH] iommu/qcom:fix local_base status check | From | Tang Bin <> | Date | Thu, 16 Apr 2020 18:12:56 +0800 |
| |
On 2020/4/16 18:05, Robin Murphy wrote: > On 2020-04-02 7:33 am, Tang Bin wrote: >> Release resources when exiting on error. >> >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> >> --- >> drivers/iommu/qcom_iommu.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c >> index 4328da0b0..c08aa9651 100644 >> --- a/drivers/iommu/qcom_iommu.c >> +++ b/drivers/iommu/qcom_iommu.c >> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct >> platform_device *pdev) >> qcom_iommu->dev = dev; >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (res) >> + if (res) { >> qcom_iommu->local_base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(qcom_iommu->local_base)) >> + return PTR_ERR(qcom_iommu->local_base); >> + } > > ...or just use devm_platform_ioremap_resource() to make the whole > thing simpler. Yes, I was going to simplify the code here, but status check is still required.
So I'm waiting.
Thanks,
Tang Bin
| |