Messages in this thread | | | Date | Thu, 16 Apr 2020 10:50:49 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node |
| |
On Wed, Apr 15, 2020 at 11:17:16AM -0700, Jonathan Bakker wrote:
> >> > >>> + > >>> + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > >>> + assigned-clock-rates = <0>, <66700000>; > >>> + assigned-clock-parents = <&clocks MOUT_MPLL>; > >> > >> Probably this should have status disabled because you do not set > >> regulator supply. > > I don't believe there is a regulator on s5pv210, if there is, then it is a > fixed regulator with no control on both s5pv210 devices that I have. > > The vendor driver did use the regulator framework for its power domain > implementation, but that definitely shouldn't be upstreamed.
Starting with Exynos4210 usually they have separate regulator from PMIC but maybe S5Pv210 indeed is different. Leave it then without it.
Best regards, Krzysztof
| |