lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/7] mmc: sdhci: fix base clock usage in preset value
    From
    Date
    On 15/04/20 7:28 pm, Michał Mirosław wrote:
    > On Wed, Apr 15, 2020 at 03:25:52PM +0300, Adrian Hunter wrote:
    >> On 2/04/20 2:54 pm, Michał Mirosław wrote:
    >>> Fixed commit added an unnecessary read of CLOCK_CONTROL. The value read
    >>> is overwritten for programmable clock preset, but is carried over for
    >>> divided clock preset. This can confuse sdhci_enable_clk() if the register
    >>> has enable bits set for some reason at time time of clock calculation.
    >>> value to be ORed with enable flags. Remove the read.
    >>
    >> The read is not needed, but drivers usually manage the enable bits,
    >> especially disabling the clock before changing the frequency. What driver
    >> is it?
    >
    > Hopefully no driver requires this. It's just removing a trap.

    The only driver that looks like it would benefit is sdhci-brcmstb because it
    does not clear enable bits in sdhci_brcmstb_set_clock(). Adding Al Cooper.
    Al, can you ack this?

    \
     
     \ /
      Last update: 2020-04-16 10:34    [W:2.842 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site