Messages in this thread | | | From | Brian Norris <> | Date | Thu, 16 Apr 2020 20:19:42 -0700 | Subject | Re: [PATCH v2 1/1] pinctrl: cherryview: Add missing spinlock usage in chv_gpio_irq_handler |
| |
[Regarding subject: this says v2 -- where's v1?]
Hi,
On Thu, Apr 16, 2020 at 8:07 PM Grace Kao <grace.kao@intel.com> wrote: > > According to Braswell NDA Specification Update (#557593), > concurrent read accesses may result in returning 0xffffffff and write > instructions may be dropped. We have an established format for the > commit references, i.e. > cdca06e4e859 ("pinctrl: baytrail: Add missing spinlock usage in > byt_gpio_irq_handler") >
Might deserve a Fixes tag and Cc stable:
Fixes: 0bd50d719b00 pinctrl: cherryview: prevent concurrent access to GPIO controllers Cc: stable@vger.kernel.org>
> Signed-off-by: Grace Kao <grace.kao@intel.com>
Seems like you should at least give me the reporter credit, if not the actual authorship, since I did in fact write this patch...
Reported-by: Brian Norris <briannorris@chromium.org>
And since I approve of my own patch:
Reviewed-by: Brian Norris <briannorris@chromium.org>
| |