Messages in this thread | | | From | Vincent Guittot <> | Date | Thu, 16 Apr 2020 09:40:22 +0200 | Subject | Re: [PATCH v3 1/9] sched/fair: find_idlest_group(): Remove unused sd_flag parameter |
| |
On Wed, 15 Apr 2020 at 23:05, Valentin Schneider <valentin.schneider@arm.com> wrote: > > The last use of that parameter was removed by commit > > 57abff067a08 ("sched/fair: Rework find_idlest_group()") > > Get rid of the parameter. > > Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> > Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
This patch is not directly related to others
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> --- > kernel/sched/fair.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 02f323b85b6d..98321d8dde7e 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5821,8 +5821,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, > } > > static struct sched_group * > -find_idlest_group(struct sched_domain *sd, struct task_struct *p, > - int this_cpu, int sd_flag); > +find_idlest_group(struct sched_domain *sd, struct task_struct *p, int this_cpu); > > /* > * find_idlest_group_cpu - find the idlest CPU among the CPUs in the group. > @@ -5905,7 +5904,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p > continue; > } > > - group = find_idlest_group(sd, p, cpu, sd_flag); > + group = find_idlest_group(sd, p, cpu); > if (!group) { > sd = sd->child; > continue; > @@ -8677,8 +8676,7 @@ static bool update_pick_idlest(struct sched_group *idlest, > * Assumes p is allowed on at least one CPU in sd. > */ > static struct sched_group * > -find_idlest_group(struct sched_domain *sd, struct task_struct *p, > - int this_cpu, int sd_flag) > +find_idlest_group(struct sched_domain *sd, struct task_struct *p, int this_cpu) > { > struct sched_group *idlest = NULL, *local = NULL, *group = sd->groups; > struct sg_lb_stats local_sgs, tmp_sgs; > -- > 2.24.0 >
| |