Messages in this thread | | | Subject | Re: [PATCH v2] i2c: busses: remove duplicate dev_err() | From | Joe Perches <> | Date | Thu, 16 Apr 2020 12:34:10 -0700 |
| |
On Thu, 2020-04-16 at 20:22 +0200, Markus Elfring wrote: > > it will print an error message by itself when platform_get_irq() > > goes wrong. so don't need dev_err() in here again. > > I suggest to improve the commit message considerably.
I suggest you ignore Markus' suggestion.
The commit message is OK.
The subject _could_ have included "platform_get_irq" something like
Subject: [PATCH v2] i2c: busses: Remove platform_get_irq()'s duplicated dev_err()
but I believe it's not important enough to redo.
| |