Messages in this thread | | | Subject | Re: [PATCH 3/5] net: macb: fix macb_get/set_wol() when moving to phylink | From | Florian Fainelli <> | Date | Thu, 16 Apr 2020 12:22:24 -0700 |
| |
On 4/16/2020 10:44 AM, nicolas.ferre@microchip.com wrote: > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > Keep previous function goals and integrate phylink actions to them. > > phylink_ethtool_get_wol() is not enough to figure out if Ethernet driver > supports Wake-on-Lan. > Initialization of "supported" and "wolopts" members is done in phylink > function, no need to keep them in calling function. > > phylink_ethtool_set_wol() return value is not enough to determine > if WoL is enabled for the calling Ethernet driver. Call if first > but don't rely on its return value as most of simple PHY drivers > don't implement a set_wol() function. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Harini Katakam <harini.katakam@xilinx.com> > Cc: Rafal Ozieblo <rafalo@cadence.com> > Cc: Antoine Tenart <antoine.tenart@bootlin.com> > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |