Messages in this thread | | | Subject | Re: [PATCH 2/5] net: macb: mark device wake capable when "magic-packet" property present | From | Florian Fainelli <> | Date | Thu, 16 Apr 2020 12:21:48 -0700 |
| |
On 4/16/2020 10:44 AM, nicolas.ferre@microchip.com wrote: > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > Change the way the "magic-packet" DT property is handled in the > macb_probe() function, matching DT binding documentation. > Now we mark the device as "wakeup capable" instead of calling the > device_init_wakeup() function that would enable the wakeup source. > > For Ethernet WoL, enabling the wakeup_source is done by > using ethtool and associated macb_set_wol() function that > already calls device_set_wakeup_enable() for this purpose. > > That would reduce power consumption by cutting more clocks if > "magic-packet" property is set but WoL is not configured by ethtool. > > Fixes: 3e2a5e153906 ("net: macb: add wake-on-lan support via magic packet") > Cc: Claudiu Beznea <claudiu.beznea@microchip.com> > Cc: Harini Katakam <harini.katakam@xilinx.com> > Cc: Rafal Ozieblo <rafalo@cadence.com> > Cc: Sergio Prado <sergio.prado@e-labworks.com> > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |