Messages in this thread | | | From | Harini Katakam <> | Subject | RE: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines | Date | Thu, 16 Apr 2020 18:26:42 +0000 |
| |
Hi Nicolas,
> -----Original Message----- > From: nicolas.ferre@microchip.com [mailto:nicolas.ferre@microchip.com] > Sent: Thursday, April 16, 2020 11:14 PM > To: linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; Claudiu > Beznea <claudiu.beznea@microchip.com>; Harini Katakam > <harinik@xilinx.com> > Cc: linux-kernel@vger.kernel.org; David S. Miller <davem@davemloft.net>; > Alexandre Belloni <alexandre.belloni@bootlin.com>; pthombar@cadence.com; > sergio.prado@e-labworks.com; antoine.tenart@bootlin.com; > f.fainelli@gmail.com; linux@armlinux.org.uk; andrew@lunn.ch; Michal Simek > <michals@xilinx.com>; Nicolas Ferre <nicolas.ferre@microchip.com>; Rafal > Ozieblo <rafalo@cadence.com> > Subject: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume > routines > > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > Use the proper struct device pointer to check if the wakeup flag and wakeup > source are positioned. > Use the one passed by function call which is equivalent to &bp->dev- > >dev.parent. > > It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan > feature is used.
Sorry I have some mail issues; meant to reply earlier. Tested patches 1, 2, 3 in this set and they work for me.
I'll try patch 4; it looks similar to what I'm using locally but I'll add whatever tie-off queue handling is required on top of your series, thanks.
Regards, Harini
| |