lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: Fixes tags needs some work in the sound-asoc tree
From
Date


On 4/15/20 6:41 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 101001652ee7 ("ASoC: SOF: topology: fix: handle DAI widget connections properly with multiple CPU DAI's")
>
> Fixes tag
>
> Fixes: 4a7e26a4d833 ("ASoC: SOF: topology: connect dai widget to all
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: c59aca98c912 ("ASoC: SOF: topology: connect dai widget to all cpu-dais")
>
> Also, please do not split Fixes tags over more than one line and keep
> all the commit message tags together at the end of the commit message.

Sorry about that. I always run checkpatch.pl and didn't see an error

../patches/20200415/0001-ASoC-SOF-topology-fix-handle-DAI-widget-connections-.patch
-----------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 49 lines checked

My theory is that the SHA1 check is fooled by our use of worktrees. This
SHA1 does exist but on another SOF development branch. Is there a way to
restrict the checks only to the base upstream branch, e.g. Mark's
for-5.8 branch?

If not, we probably need to make sure we have a separate directory just
for upstreaming, to avoid any pollution from SOF branches?

Thanks
-Pierre

\
 
 \ /
  Last update: 2020-04-16 18:52    [W:0.085 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site