Messages in this thread | | | Date | Thu, 16 Apr 2020 18:35:21 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] mips: define pud_index() regardless of page table folding |
| |
On Thu, Apr 02, 2020 at 11:16:14AM +0300, Mike Rapoport wrote: > From: Mike Rapoport <rppt@linux.ibm.com> > > Commit 31168f033e37 ("mips: drop __pXd_offset() macros that duplicate > pXd_index() ones") is correct that pud_index() & __pud_offset() are the > same when pud_index() is actually provided, however it does not take into > account the __PAGETABLE_PUD_FOLDED case. This has broken MIPS KVM > compilation because it relied on availability of pud_index(). > > Define pud_index() regardless of page table folded. It will evaluate to > actual index for 4-level pagetables and to 0 for folded PUD level. > > Link: https://lore.kernel.org/lkml/20200331154749.5457-1-pbonzini@redhat.com > Reported-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > --- > arch/mips/include/asm/pgtable-64.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |